microsoft / microsoft/vscode

[gh-aw] Protected Files: fix: defer chat list height update to next animation frame (fixes #316501)

Open
#328,114 0 comments 0 reactions 0 assignees View on GitHub
agentic-workflows
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

> [!WARNING]
> **Protected Files**
>
> The push to pull request branch was blocked because the patch modifies protected files.
>
> **Target Pull Request:** [#316671](https://github.com/microsoft/vscode/pull/316671)
>
> **Please review the changes carefully** before pushing them to the pull request branch. These files may affect project dependencies, CI/CD pipelines, or agent behaviour.
>
>
> Protected files
>
> - `README.md`
- `package-lock.json`
- `package.json`
- `AGENTS.md`
- `CONTRIBUTING.md`
- `CODEOWNERS`
- `pnpm-lock.yaml`
- [.vscode/launch.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/launch.json)
- [.vscode/notebooks/endgame.github-issues](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/notebooks/endgame.github-issues)
- [.vscode/notebooks/my-endgame.github-issues](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/notebooks/my-endgame.github-issues)
- [.eslint-plugin-local/code-no-direct-gulp-import.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.eslint-plugin-local/code-no-direct-gulp-import.ts)
- [.vscode/extensions/vscode-pr-pinger/package-lock.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/extensions/vscode-pr-pinger/package-lock.json)
- [.vscode/extensions/vscode-pr-pinger/package.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/extensions/vscode-pr-pinger/package.json)
- [.eslint-plugin-local/index.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.eslint-plugin-local/index.ts)
- [.vscode/extensions/vscode-extras/src/npmUpToDateFeature.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/extensions/vscode-extras/src/npmUpToDateFeature.ts)
- [.devcontainer/README.md](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.devcontainer/README.md)
- [.agents/skills/launch/SKILL.md](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.agents/skills/launch/SKILL.md)
- [.agents/skills/launch/scripts/launch.sh](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.agents/skills/launch/scripts/launch.sh)
- [.agents/skills/launch/scripts/monaco-paste.sh](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.agents/skills/launch/scripts/monaco-paste.sh)
- [.devcontainer/Dockerfile](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.devcontainer/Dockerfile)
- [.vscode/extensions/vscode-selfhost-test-provider/package-lock.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/extensions/vscode-selfhost-test-provider/package-lock.json)
- [.vscode/extensions/vscode-selfhost-test-provider/package.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/extensions/vscode-selfhost-test-provider/package.json)
- [.vscode/settings.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/settings.json)
- [.scratch-theme-test/sample.cpp](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.cpp)
- [.scratch-theme-test/sample.css](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.css)
- [.scratch-theme-test/sample.go](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.go)
- [.scratch-theme-test/sample.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.json)
- [.scratch-theme-test/sample.md](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.md)
- [.scratch-theme-test/sample.py](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.py)
- [.scratch-theme-test/sample.sh](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.sh)
- [.scratch-theme-test/sample.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.scratch-theme-test/sample.ts)
- [.vscode/tasks.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/tasks.json)
- [.eslint-plugin-local/code-no-new-javascript-files.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.eslint-plugin-local/code-no-new-javascript-files.ts)
- [.vscode/notebooks/api.github-issues](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/notebooks/api.github-issues)
- [.eslint-plugin-local/code-no-untyped-meta-access.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.eslint-plugin-local/code-no-untyped-meta-access.ts)
- [.vscode/cglicenses.schema.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.vscode/cglicenses.schema.json)
- [.eslint-plugin-local/code-no-deprecated-copilot-sdk.ts](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.eslint-plugin-local/code-no-deprecated-copilot-sdk.ts)
- [.devcontainer/devcontainer-lock.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.devcontainer/devcontainer-lock.json)
- [.devcontainer/devcontainer.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.devcontainer/devcontainer.json)
- [.eslint-plugin-local/package.json](https://github.com/microsoft/vscode/blob/fix/resize-observer-loop-316501-e5237abb1e1fd22a/.eslint-plugin-local/package.json)
>
>

---

Apply the patch after review

The patch is available in the workflow run artifacts:

**Workflow Run:** [View run details and download patch artifact](https://github.com/microsoft/vscode-engineering/actions/runs/30493383736)

```sh
# Download the artifact from the workflow run
gh run download 30493383736 -n agent -D /tmp/agent-30493383736

# Apply the patch to the pull request branch
git fetch origin fix/resize-observer-loop-316501-e5237abb1e1fd22a
git checkout fix/resize-observer-loop-316501-e5237abb1e1fd22a
git am --3way /tmp/agent-30493383736/aw-microsoft-vscode-fix-resize-observer-loop-316501-e5237abb1e1fd22a.patch
git push origin fix/resize-observer-loop-316501-e5237abb1e1fd22a
```

To route changes like this to a review issue instead of blocking, configure `protected-files: fallback-to-issue` in your workflow configuration.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing target pull request #316671 and downloading the patch artifact from workflow run 30493383736. Inspect the changed files and verify that the chat list height update is deferred to the next animation frame, with the existing pull request checks passing as the completion criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.