microsoft / microsoft/vscode

[gh-aw] Protected Files: fix: guard against undefined isDefaultForLocation in deserialized chat state (fixes #317793)

Open
#327,996 0 comments 0 reactions 0 assignees View on GitHub
agentic-workflows
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

> [!WARNING]
> **Protected Files**
>
> The push to pull request branch was blocked because the patch modifies protected files.
>
> **Target Pull Request:** [#317802](https://github.com/microsoft/vscode/pull/317802)
>
> **Please review the changes carefully** before pushing them to the pull request branch. These files may affect project dependencies, CI/CD pipelines, or agent behaviour.
>
>
> Protected files
>
> - `README.md`
- `CONTRIBUTING.md`
- `package-lock.json`
- `package.json`
- `AGENTS.md`
- `CODEOWNERS`
- `pnpm-lock.yaml`
- [.vscode/extensions/vscode-extras/src/npmUpToDateFeature.ts](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/extensions/vscode-extras/src/npmUpToDateFeature.ts)
- [.devcontainer/README.md](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.devcontainer/README.md)
- [.agents/skills/launch/SKILL.md](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.agents/skills/launch/SKILL.md)
- [.agents/skills/launch/scripts/launch.sh](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.agents/skills/launch/scripts/launch.sh)
- [.vscode/notebooks/endgame.github-issues](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/notebooks/endgame.github-issues)
- [.vscode/notebooks/my-endgame.github-issues](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/notebooks/my-endgame.github-issues)
- [.agents/skills/launch/scripts/monaco-paste.sh](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.agents/skills/launch/scripts/monaco-paste.sh)
- [.devcontainer/Dockerfile](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.devcontainer/Dockerfile)
- [.vscode/extensions/vscode-selfhost-test-provider/package-lock.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/extensions/vscode-selfhost-test-provider/package-lock.json)
- [.vscode/extensions/vscode-selfhost-test-provider/package.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/extensions/vscode-selfhost-test-provider/package.json)
- [.vscode/launch.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/launch.json)
- [.vscode/settings.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/settings.json)
- [.scratch-theme-test/sample.cpp](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.cpp)
- [.scratch-theme-test/sample.css](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.css)
- [.scratch-theme-test/sample.go](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.go)
- [.scratch-theme-test/sample.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.json)
- [.scratch-theme-test/sample.md](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.md)
- [.scratch-theme-test/sample.py](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.py)
- [.scratch-theme-test/sample.sh](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.sh)
- [.scratch-theme-test/sample.ts](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.scratch-theme-test/sample.ts)
- [.vscode/tasks.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/tasks.json)
- [.eslint-plugin-local/code-no-new-javascript-files.ts](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.eslint-plugin-local/code-no-new-javascript-files.ts)
- [.vscode/notebooks/api.github-issues](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/notebooks/api.github-issues)
- [.eslint-plugin-local/code-no-untyped-meta-access.ts](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.eslint-plugin-local/code-no-untyped-meta-access.ts)
- [.vscode/cglicenses.schema.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.vscode/cglicenses.schema.json)
- [.eslint-plugin-local/code-no-deprecated-copilot-sdk.ts](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.eslint-plugin-local/code-no-deprecated-copilot-sdk.ts)
- [.devcontainer/devcontainer-lock.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.devcontainer/devcontainer-lock.json)
- [.devcontainer/devcontainer.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.devcontainer/devcontainer.json)
- [.eslint-plugin-local/package.json](https://github.com/microsoft/vscode/blob/fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23/.eslint-plugin-local/package.json)
>
>

---

Apply the patch after review

The patch is available in the workflow run artifacts:

**Workflow Run:** [View run details and download patch artifact](https://github.com/microsoft/vscode-engineering/actions/runs/30450245435)

```sh
# Download the artifact from the workflow run
gh run download 30450245435 -n agent -D /tmp/agent-30450245435

# Apply the patch to the pull request branch
git fetch origin fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23
git checkout fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23
git am --3way /tmp/agent-30450245435/aw-microsoft-vscode-fix-chat-isdefaultforlocation-undefined-317793-274a3fd1432a8f23.patch
git push origin fix/chat-isDefaultForLocation-undefined-317793-274a3fd1432a8f23
```

To route changes like this to a review issue instead of blocking, configure `protected-files: fallback-to-issue` in your workflow configuration.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing target pull request #317802 and the patch artifact from workflow run 30450245435, then inspect the referenced TypeScript change in .vscode/extensions/vscode-extras/src/npmUpToDateFeature.ts. Confirm the fix safely handles deserialized chat state when isDefaultForLocation is undefined, and validate the target pull request before applying or changing the patch.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd, developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.