microsoft / microsoft/vscode

Document highlights sometimes disappear when renaming

Open
#327,850 0 comments 1 reaction 1 assignee Claimed by @Yoyokrazy View on GitHub
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

When renaming symbols in TypeScript, sometimes the document highlights refresh after the rename, and sometimes they just disappear.

Here, when I rename the parameter from the left hand side, the document highlights return after the rename. But when I rename from the right hand side, the document highlights vanish and don't come back.

https://github.com/user-attachments/assets/c5e617b8-dbbf-44f7-a1b3-df8642a9f4e9

I can't see anything in the API related to this, so I presume that when the `WorkspaceEdit` is applied, VS Code should re-request document highlights, but I don't know why it's only doing it in some cases (or whether it might be a race - though it seems consistent as it occurred in the video above).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.