microsoft / microsoft/vscode

Spurious test failures in ChatListRenderer.fireItemHeightChange

Open
#327,402 1 comment 0 reactions 1 assignee Claimed by @justschen View on GitHub
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

https://github.com/microsoft/vscode/actions/runs/30125958708/job/89589396846?pr=327391
(https://github.com/microsoft/vscode/pull/327391)
https://github.com/microsoft/vscode/actions/runs/30128189422/job/89597727903?pr=327248

```
1) ChatListRenderer
fireItemHeightChange defers a mid-render measurement and delivers it after the render pass:


+ expected - actual

{
"events": [
- 86
+ 114
]
- "stored": 86
+ "stored": 114
}

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

{
events: [
+ 86
- 114
],
+ stored: 86
- stored: 114
}

at Context. (file:///Users/runner/work/vscode/vscode/out/vs/workbench/contrib/chat/test/browser/widget/chatListRenderer.test.js:564:12)
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.