microsoft / microsoft/vscode

Exploitable DOS from extension, CVE-2022-25883

Open
#326,828 2 comments 0 reactions 1 assignee Claimed by @meganrogge View on GitHub
tasks
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

Does this issue occur when all extensions are disabled?: No

- VS Code Version: 1.129.0
- OS Version: any

Steps to Reproduce:

1. In a VSCode extension, run this code: `vscode.tasks.fetchTasks({ version: '1.2.3' + ' '.repeat(128000) + '<1.3.0' })`
2. The UI is now completely frozen for seconds (the higher the value, the longest is the freeze)

It's related to the [CVE-2022-25883](https://github.com/advisories/GHSA-c2qf-rxjj-qqgw), since the inlined version of semver in VSCode is the [5.5.0](https://github.com/microsoft/vscode/blob/main/src/vs/base/common/semver/cgmanifest.json)

Updating semver to the last version would solve the issue

Only the [electron version seems to be impacted](https://github.com/microsoft/vscode/blob/d28fc4f1fb9fce487efeff34313228a7eebd2c53/src/vs/workbench/contrib/tasks/electron-browser/taskService.ts#L178)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.