microsoft / microsoft/vscode

Package.json dependency metadata lookup; slow with PNPM

Open
#326,140 1 comment 0 reactions 1 assignee Claimed by @aeschli View on GitHub
npm
Dominant language
TypeScript
Stars
193k
Forks
42.4k
PR merge metrics
PR metrics pending

Description

Does this issue occur when all extensions are disabled?: Yes.

- VS Code Version: 1.129.0
- OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

- Create a new project using PNPM.
- Begin adding dependencies to the project.
- Try to hover over a dependency name/semver to get version metadata info box.

The more dependencies that get added to the project, the slower the tooltip hover becomes when hovering a dependency name/semver, until it maxes out at about 8 seconds of displaying a temporary "loading..." tooltip box, when the project contains hundreds or more dependencies.

- Adding `node-linker=hoisted` to an `.npmrc` file resolves the delay to less than 1 second.
- Changing .vscode/settings.json `"npm.packageManager": "pnpm"` has no effect
- Adding the following to .vscode/settings.json has no effect:
```
"files.watcherExclude": {
"**/node_modules/**": true,
"**/.pnpm/**": true
},
"search.exclude": {
"**/node_modules/**": true,
"**/.pnpm/**": true
}
```

It appears that vscode chokes on traversing the PNPM style node_modules folder. The hover feature otherwise works as it should for non-dependency package.json fields and in non-PNPM repos.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.