Voice Mode: Follow-up improvements from PR review

Open
#321,069 0 comments 0 reactions 1 assignee View on GitHub

@meganrogge is already working on this.

Since Jun 12, 2026.

Assessment

This issue has not been assessed yet.

Description

Follow-up items deferred from #320785 based on review feedback from @dmitrivMS.

1. Replace polling with observables/events in agentsVoiceWindowService

Comment: agentsVoiceWindowService.ts:275

The session polling (setInterval every 3s to call agentSessionsService.model.resolve()) is a workaround. We should subscribe to proper events/observables for session state changes instead of polling.

2. Make BroadcastChannel window-scoped

Comments: agentsVoiceWidget.ts:176, chatViewPane.ts:398

The BroadcastChannel used for communication between the voice controller and the chat widget is global. If two chat panes or windows race on commands like getCurrentSession, the last one wins. This should be scoped per-window to prevent conflicts.

cc @meganrogge

Dominant language
TypeScript
Stars
193k
Forks
42.9k
PR metrics pending

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/vscode

All issues in microsoft/vscode

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.