microsoft / microsoft/vscode-typescript-next

Elusive breakage of `Add all missing imports` source action. Needs further investigation.

Open
#134 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
299
Forks
49
PR merge metrics
No merged PRs in 30d

Description

The JavaScript and TypeScript Nightly v5.7.20240911 update broke some part of the Add all missing imports source action. Ever since then, some imports would be incorrectly imported with the type only attribute; i.e.

import type {} from "";

instead of

import {} from "";

for situations where type only imports are not correct.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Add all missing imports source action with the JavaScript and TypeScript Nightly v5.7.20240911 update. Compare cases where it generates import type {} with cases requiring import {}; done means type-only imports are no longer used for value-only imports.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.