microsoft / microsoft/vscode-textmate
Format strings not being handled in grammar
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 678
- Forks
- 135
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 2
Description
Given the grammar:
https://github.com/textmate/markdown.tmbundle/blob/master/Syntaxes/Markdown.tmLanguage it seems that vscode can't properly handle the construct https://github.com/textmate/markdown.tmbundle/blob/master/Syntaxes/Markdown.tmLanguage#L105
i.e.: when parsing a markdown with '##' with this construct (markup.heading.${1/(#)(#)?(#)?(#)?(#)?(#)?/${6:?6:${5:?5:${4:?4:${3:?3:${2:?2:1}}}}}/}.markdown), it'd be expected that the result is markup.heading.2.markdown, whereas vscode is just giving markup.heading.${1/(#)(#)?(#)?(#)?(#)?(#)?/${6:?6:${5:?5:${4:?4:${3:?3:${2:?2:1}}}}}/}.markdown as the result.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced Markdown.tmLanguage construct around line 105 and reproduce the heading case described in the issue. Trace how the library handles the grammar's format-string substitution, and consider the work complete when the construct resolves to markup.heading.2.markdown instead of retaining the interpolation expression.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100