microsoft / microsoft/vscode-textmate
Scoping Issues For Relative Rule References
Open
@hediet is already working on this.
Since May 2, 2022.
bug
- Dominant language
- TypeScript
- Stars
- 678
- Forks
- 135
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 2
Description
This line collects the dependencies of a relative reference:
https://github.com/microsoft/vscode-textmate/blob/9157c7f869219dbaf9a5a5607f099c00fe694a29/src/grammar.ts#L139
However, it passes in the patternRepository of the current rule.
collectSpecificDependencies then continues to use this patternRepository as new local context for resolving relative references.
However, collectSpecificDependencies should continue with the repository of its own parents.
Related: https://github.com/microsoft/vscode-textmate/issues/174
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.