microsoft / microsoft/vscode-test-cli
Since types from `@vscode/test-electron` are reexported, it should be a regular (non-dev) dependency
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 53
- Forks
- 16
- Avg merge
- 10h 57m
- Merged PRs (30d)
- 2
Description
A type from @vscode/test-electron is imported here:
https://github.com/microsoft/vscode-test-cli/blob/044359f9cebf187b5702a768aff5d4640a152632/src/config.cts#L5
And then reexported here:
https://github.com/microsoft/vscode-test-cli/blob/044359f9cebf187b5702a768aff5d4640a152632/src/config.cts#L139
As a result, @vscode/test-electron should ideally be a regular (non-dev) dependency. Otherwise, type errors result if the consumer doesn't also explicitly install @vscode/test-electron as a dev dependency in package.json.
I can submit a PR to fix this. Or, Copilot could probably handle it easily.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/config.cts, especially the import around line 5 and reexport around line 139, then inspect the package manifest's dependency declarations. Move @vscode/test-electron from development-only dependencies to regular dependencies, and verify that consumers no longer need to install it separately for the reexported type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100