microsoft / microsoft/vscode-sublime-keybindings
Sublime Extension prompt shown should not be stored in user settings
Open
@rebornix is already working on this.
Since Dec 1, 2017.
bug
- Dominant language
- TypeScript
- Stars
- 257
- Forks
- 128
- PR merge metrics
- No merged PRs in 30d
Description
From @alexandrudima on June 27, 2017 9:20
Testing #29144
"sublimeTextKeymap.promptV3Features": true
This should not be a user-facing setting. Extensions should store state using the context object passed into the activate function.
Instead, I suggest the following:
- contribute a command called: "Customize VS Code with Sublime Text settings"
- this will ensure that the user can invoke the command palette and invoke the customize action independently of the prompt and repeatedly.
- once user interaction has been made with the prompt (i.e. YES or NO, but not More info), the
context.globalStatepassed in theactivatemethod should be used to store the flag that the prompt should not be shown again.- when
YESis pressed, invoke the command you have contributed and write toglobalStatethat the prompt should not be shown again. - when
NOis pressed, write toglobalStatethat the prompt should not be shown again. - when
More infois pressed, open the help page.
- when
For testing purposes, I believe the extension global state can be cleared via Developer Tools > Application > Local Storage
Copied from original issue: Microsoft/vscode#29546
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.