microsoft / microsoft/vscode-spring-boot-dashboard
Seek for better way to shutdown the app gracefully.
Open
Nobody has claimed this yet.
discussion
enhancement
- Dominant language
- TypeScript
- Stars
- 73
- Forks
- 38
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 15
Description
Code here:
https://github.com/Microsoft/vscode-spring-boot-dashboard/blob/master/src/Controller.ts#L57-L65
In MacOSX, after clicking "Stop", sending "SIGINT" to kill, the value of app.process.killed is true, but actually the process is not terminated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Controller.ts around lines 57-65 and reproduce the Stop action on macOS. Inspect how SIGINT is sent and why app.process.killed becomes true while the process remains running. Done means the stopped process is actually terminated after the action.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100