Postinstall.js leaves tmp directory around

Open
#8 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript, node.js

Research direction

Start with lib/download.js at lines 254-256 and trace how the postinstall.js flow creates and uses the temporary directory. Confirm the cleanup behavior after the download completes, then verify that the temporary directory is removed in the relevant install path.

Written by the indexing model from the issue text.

Description

I know it's minor, but that temporary directory created here is not removed
https://github.com/microsoft/vscode-ripgrep/blob/c96015299d6d5cbe26be317181c4556273c2503c/lib/download.js#L254-L256

Dominant language
JavaScript
Stars
203
Forks
66
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/vscode-ripgrep

All issues in microsoft/vscode-ripgrep

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.