microsoft / microsoft/vscode-remote-release

SSH still available in container even I disable `forwardWSLServices`

Open
#9,897 7 comments 3 reactions 1 assignee View on GitHub

@chrmarti is already working on this.

Since May 17, 2024.

containers feature-request
Dominant language
Dockerfile
Stars
4.2k
Forks
469
Avg merge
1d 1h
Merged PRs (30d)
1

Description

SSH inside container can connect to GitHub even if I disable forwardWSLServices and gitCredentialHelperConfigLocation.

There are no keys in ~/.ssh (inside container) and no helper in git config -l

My settings:

"dev.containers.copyGitConfig": false,
  "dev.containers.defaultExtensions": [
    "editorconfig.editorconfig",
    "connor4312.nodejs-testing",
    "dbaeumer.vscode-eslint",
    "esbenp.prettier-vscode",
    "yoavbls.pretty-ts-errors",
    "streetsidesoftware.code-spell-checker",
    "editorconfig.editorconfig",
    "yzhang.markdown-all-in-one",
    "christian-kohler.path-intellisense",
    "christian-kohler.npm-intellisense",
    "VisualStudioExptTeam.vscodeintellicode",
    "davidlday.languagetool-linter"
  ],
  "dev.containers.dockerCredentialHelper": false,
  "dev.containers.dockerPath": "podman",
  "dev.containers.forwardWSLServices": false,
  "dev.containers.gitCredentialHelperConfigLocation": "none",
  "dev.containers.mountWaylandSocket": false,
  "dotfiles.installCommand": "devcontainer/install-dotfiles",
  "dotfiles.repository": "ai/environment",
  • VSCode Version: 1.89.1

  • Local OS Version: Fedora 40

  • Remote OS Version: ubuntu:24.04

  • Remote Extension/Connection Type: Containers

  • Logs:

Steps to Reproduce:

  1. Disable forwardWSLServices, and gitCredentialHelperConfigLocation
  2. Open local project in container
  3. Open container terminal in VS Code
  4. Run ssh -T git@github.com
  5. See container has SSH access to GitHub

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.