microsoft / microsoft/vscode-remote-release

Devcontainer extension detects RAM hostRequirement incorrectly

Open
#8,960 2 comments 0 reactions 1 assignee View on GitHub

@chrmarti is already working on this.

Since Sep 29, 2023.

bug containers upstream
Dominant language
Dockerfile
Stars
4.2k
Forks
470
Avg merge
1d 1h
Merged PRs (30d)
1

Description

When I define a devcontainer with memory requirements of the same size of my host memory, the extension warns me that Not all host requirements in devcontainers.json are met by the docker daemon.

devcontainers-wrong-ram-detection

I wonder if this is a case of a < instead of <= comparison.

  • VSCode Version:
    Version: 1.82.0
    Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
    Date: 2023-09-06T22:07:18.759Z
    Electron: 25.8.0
    ElectronBuildId: 23503258
    Chromium: 114.0.5735.289
    Node.js: 18.15.0
    V8: 11.4.183.29-electron.0

  • Local OS: Linux x64 6.2.0-32-generic

  • Remote OS Version: Ubuntu 20.04 (Universal devcontainer image)

  • Remote Extension/Connection Type: Containers

  • Logs:

Steps to Reproduce:

  1. Create a devcontainer definition with the hostRequirement of the size of the memory on your computer, in my case 32GB
  "hostRequirements": {
    "memory": "32gb"
  },
  1. Open in container, it will open a warning saying that the memory requirements are not met even if they do.

Does this issue occur when you try this locally?: Yes
Does this issue occur when you try this locally and all extensions are disabled?: ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.