microsoft / microsoft/vscode-remote-release
Support dockerfile_inline option docker-compose syntax
Open
Nobody has claimed this yet.
containers
feature-request
- Dominant language
- Dockerfile
- Stars
- 4.2k
- Forks
- 470
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
I'd like to use the dockerfile_inline option with dev containers, it currently doesn't appear to work:
[2023-05-05T00:09:50.603Z] Start: Run: docker compose -f ********/composed-envs/***/***_daemon/docker-compose.yml --profile * config
[2023-05-05T00:09:50.642Z] Stop (39 ms): Run: docker compose -f ********/composed-envs/***/***_daemon/docker-compose.yml --profile * config
[2023-05-05T00:09:50.642Z] name: ***_daemon
services:
***_daemon_env:
build:
context: ********/composed-envs
dockerfile_inline: "# syntax = edrevo/dockerfile-plus \n\nINCLUDE+ ./***/***_daemon/repo/Dockerfile-dev\nINCLUDE+
./Dockerfile-common\n"
args:
DEV_USER: vscode
cap_add:
- SYS_ADMIN
command:
- tail
- -f
- /dev/null
devices:
- /opt/fuse:/opt/fuse:rwm
init: true
ipc: host
networks:
default: null
privileged: true
secrets:
- source: user_ssh_key
volumes:
- type: bind
source: ********/composed-envs
target: /workspace/src
bind:
create_host_path: true
- type: bind
source: /var/run/docker.sock
target: /var/run/docker.sock
bind:
create_host_path: true
[2023-05-05T00:09:50.645Z] Error: ENOENT: no such file or directory, open '********/composed-envs/Dockerfile'
[2023-05-05T00:09:50.648Z] Stop (291 ms): Run: /usr/share/code/code --ms-enable-electron-run-as-node ********/.vscode/extensions/ms-vscode-remote.remote-containers-0.293.0/dist/sp
[2023-05-05T00:09:50.648Z] Exit code 1
It appears to think there should be a Dockerfile somewhere when it can't find that key I think.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with the shown docker-compose.yml and the docker compose ... config command, then trace how dev containers process the dockerfile_inline build option. Done means a configuration using that option no longer attempts to open a missing Dockerfile and can proceed without that file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose, dockerfile
- Domain
- developer-experience, devops
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100