microsoft / microsoft/vscode-remote-release
Parsing Verification for Server Reconnection
Nobody has claimed this yet.
- Dominant language
- Dockerfile
- Stars
- 4.2k
- Forks
- 470
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
When reconnecting to a remote, remote-ssh looks for an existing vs code server of the right version to connect to and will use this if it exists. It checks by searching for data.json files at Application Support/Code - Insiders/User/globalStorage. It then parses the data.json file to get the necessary information to run/connect to the server such as the connection token.
Add verification to make sure the necessary values are found in the data.json when parsed. Right now no checking exists and so the error that is thrown is resolver error: TypeError: Cannot read properties of undefined (reading 'replace') which does not correctly explain the actual problem is related to the connection token being missing in the data.json file.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the remote-ssh reconnection path that searches Application Support/Code - Insiders/User/globalStorage for data.json files and parses them. Verify that the required values, especially the connection token, are present; done means missing values produce an explanatory connection error rather than the current undefined replace TypeError.
Written by the indexing model from the issue text.
Assessment
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100