microsoft / microsoft/vscode-remote-release
VS Code 1.69.0 installs x64 node server onto Windows 11 ARM64 remote PC and identifies platform incorrectly as x64
Nobody has claimed this yet.
- Dominant language
- Dockerfile
- Stars
- 4.2k
- Forks
- 470
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
Version: 1.69.0 (system setup)
Commit: 92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9
Date: 2022-07-07T05:28:36.503Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: 10.0.139.17-electron.0
OS: Windows_NT x64 10.0.22000
VS Code 1.69.0 (and Remote - SSH v0.83.2022070715) appears to be installing an x64 binary for node.exe onto Windows 11 ARM64 remote PC. Windows 11 can emulate x64, but is much faster at emulating x86. The x86 version of node.exe should probably be installed on Windows 11 ARM64 instead.
The worse part of this issue is that calling os.arch() from our extension identifies the platform as x64. Our extension has a check to ensure correct native binaries have been installed on the system, and it's now misidentifying Windows 11 ARM64 machines as x64 when used remotely, causing an error to be displayed (when the arm64 platform-specific VSIX is explicitly installed on the system). This only happens when using the machine remotely. os.arch() properly identifies the machine as arm64 when running fully locally on Windows 11 ARM64, with the arm64 platform-specific VSIX.
I don't see a Windows ARM64 version of node available for download from nodejs.org, but we do get the correct os.arch() when not remoting...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.