microsoft / microsoft/vscode-remote-release

Use hosts from `portsAttributes` to detect when a port should be forwarded

Open
#6,897 1 comment 0 reactions 1 assignee View on GitHub

@alexr00 is already working on this.

Since Jul 6, 2022.

feature-request remote-explorer
Dominant language
Dockerfile
Stars
4.2k
Forks
470
Avg merge
1d 1h
Merged PRs (30d)
1

Description

This is an outcome of https://github.com/microsoft/vscode-remote-release/issues/6895.

There are several places that VS Code has the opportunity to notice that a port should be forwarded:

  • terminal output (when auto forwarding is on)
  • debug console (when auto forwarding is on)
  • terminal link handling
  • the extension API openExternal

In all of these places, we only forward the port if the host is localhost, 127.0.0.1, or 0.0.0.0.

This could be improved by looking for hosts in portsAttributes and then including those hosts when deciding whether to forward.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.