microsoft / microsoft/vscode-remote-release
Feature request: Allow dynamic "runArgs" for docker
@chrmarti is already working on this.
Since Nov 9, 2020.
- Dominant language
- Dockerfile
- Stars
- 4.2k
- Forks
- 470
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
Could you somehow support a way of building and passing dynamic arguments to the docker run command? We currently only have runArgs array in devcontainer.json that is static in nature and not suitable for any sort of scripting. One use case could be, for example, to mount some extra volumes conditionally while keeping all the nice automatic devcontainer infrastructure that the remote extension has to offer. It'd be enough just to include a shell call somewhere. For example, you could introduce a string version of runArgs that would be included verbatim in the default docker run command and then the entire command would be executed by the shell. Or you could introduce a runCommand override with some pre-defined variables that users would then include in the command they specify. You could also support variables like ${workspaceFolder} in remote.containers.dockerPath so that we can hack our way through :) Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.