microsoft / microsoft/vscode-remote-release
Add `preDeleteCommand` to devcontainer.json
@chrmarti is already working on this.
Since May 13, 2020.
- Dominant language
- Dockerfile
- Stars
- 4.2k
- Forks
- 470
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
@Chuxel Moving the preDeleteCommand discussion here. I realize that this might be mainly driven by Codespaces, we just need to understand if/how it applies to Remote-Containers.
preDeleteCommand needs more discussion:
The only case where Remote-Containers deletes a container automatically is when rebuilding the container. Should it run the preDeleteCommand in that case? The container will be recreated after that.
The user can delete a container through the Remote Explorer. Should the preDeleteCommand run before that?
What if the user deletes the container through the Docker extension or some other tool or the Docker CLI? Is not running the configured command in this case good enough?
Originally posted by @chrmarti in https://github.com/microsoft/vscode-remote-release/issues/2772#issuecomment-627372461
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.