microsoft / microsoft/vscode-remote-release
Dev container volume and spaces on git repo name
Open
@chrmarti is already working on this.
Since Dec 12, 2022.
bug
containers
- Dominant language
- Dockerfile
- Stars
- 4.2k
- Forks
- 470
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
Seems that docker volume create gets broken if there is spaces (%20) on
git clone URL (like example if Azure DevOps project have spaces on name)
[2336 ms] Start: Run: docker volume create --label vsch.local.repository=https://somecompany@dev.azure.com/somecompany/xxx%20yyy%20platform/_git/some-backend --label vsch.local.repository.unique=true xxx%20yyy%20platform-3be1c63df975da8bc08207a42b340efa
[2914 ms] Command failed: docker volume create --label vsch.local.repository=https://somecompany@dev.azure.com/somecompany/xxx%20yyy%20platform/_git/some-backend --label vsch.local.repository.unique=true xxx%20yyy%20platform-3be1c63df975da8bc08207a42b340efa
On new projects I can set project name to get it working, but older projects this is pain as it's much more difficult to make changes to git paths for all users.
Maybe on creation change %20 to '-' (or similar) to be valid for label and name?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.