microsoft / microsoft/vscode-remote-release

Warn when mistyping devcontainer `build` properties

Open
#2,440 2 comments 0 reactions 1 assignee View on GitHub

@chrmarti is already working on this.

Since Feb 26, 2020.

containers feature-request
Dominant language
Dockerfile
Stars
4.2k
Forks
470
Avg merge
1d 1h
Merged PRs (30d)
1

Description

Testing https://github.com/microsoft/vscode-remote-release/issues/2409

  • Have a devcontainer file:
{
	"name": "Heyhey",
	"build": {
		"dockerFile": "Dockerfile",
		"target": "ts-node12",
		"args": {
			"FOO": "BAR"
		}
	},
``
There's and error, but not on `dockerFile` shich should be `dockerfile`.

To improve, just add a `addititionalProperties: false` on the object defining `bulid`

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.