microsoft / microsoft/vscode-remote-release

.gitconfig includeif not available inside container

Open
#2,084 23 comments 28 reactions 1 assignee View on GitHub

@chrmarti is already working on this.

Since Jan 2, 2020.

containers feature-request
Dominant language
Dockerfile
Stars
4.2k
Forks
470
Avg merge
1d 1h
Merged PRs (30d)
1

Description

  • VSCode Version:
    Version: 1.41.0-insider
    Commit: 599c076d91be1374cf51004cec610f3bcaf4c9cd
    Date: 2019-11-22T07:19:06.796Z
    Electron: 6.1.5
    Chrome: 76.0.3809.146
    Node.js: 12.4.0
    V8: 7.6.303.31-electron.0

  • Local OS Version:
    OS: Darwin x64 18.7.0

  • Remote OS Version:
    Debian 9 (mcr.microsoft.com/powershell)

  • Remote Extension/Connection Type: Docker

Steps to Reproduce:

  1. includeif in gitconfig is not honoured inside the developement container.

Local .gitconfig contains

[includeIf "gitdir/i:~/git/gitpersonal/"]
	path = ~/.gitconfig-personal

git config --list --show-origin

Local

file:/Users/brett.miller/.gitconfig     user.name=Brett Miller
file:/Users/brett.miller/.gitconfig     user.email=brett.miller@org.com
file:/Users/brett.miller/.gitconfig     includeif.gitdir/i:~/git/gitpersonal/.path=~/.gitconfig-personal
file:/Users/brett.miller/.gitconfig-personal    user.name=Brett Miller
file:/Users/brett.miller/.gitconfig-personal    user.email=brett@millerb.co.uk
file:/Users/brett.miller/.gitconfig     core.editor=code-insiders --wait

Devcontainer

file:/root/.gitconfig   user.name=Brett Miller
file:/root/.gitconfig   user.email=brett.miller@org.com
file:/root/.gitconfig   includeif.gitdir/i:~/git/gitpersonal/.path=~/.gitconfig-personal
file:/root/.gitconfig   core.editor=code-insiders --wait

Seen #1811 but didn't think it was the same thing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.