microsoft / microsoft/vscode-react-native
[Feature] Android Hermes command incorrectly updates commented configuration
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.7k
- Forks
- 295
- Avg merge
- 11h 17m
- Merged PRs (30d)
- 24
Description
Description
The current regular expression matches only hermesEnabled=false, so the
subsequent check cannot detect the leading #. As a result, the command
updates text inside the comment instead of adding an active configuration.
Expected Behavior
The command should:
Preserve the commented property.
Add a new active hermesEnabled property with the selected value.
Proposed Fix
Use a line-anchored regular expression that captures optional indentation and
the comment marker. Only update the property when the match is active;
otherwise, preserve the comment and append a new active property.
Add a regression test covering the commented-property scenario.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Android Hermes command and its configuration-update tests; first inspect the regular expression and the existing active-property path. Add the commented-property regression case, then run the relevant test to verify the comment is preserved and a new active hermesEnabled property is added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, react-native, typescript
- Domain
- mobile-dev, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 70/100