microsoft / microsoft/vscode-react-native

[Feature] Avoid recording the same app launch error multiple times in telemetry

Open
#2,919 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
2.7k
Forks
295
Avg merge
11h 17m
Merged PRs (30d)
24

Description

Description

The same exception can currently be recorded multiple times in app launch telemetry.

In appLauncher.ts, the error handler calls generator.addError() and then rethrows the exception. The rethrown exception is subsequently caught by TelemetryGenerator.time(), which automatically calls addError() again.

As a result, a single app launch failure may produce duplicate telemetry properties such as:

error.code0 = <error code>
error.code1 = <same error code>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in appLauncher.ts by tracing the error handler through generator.addError() and the rethrow into TelemetryGenerator.time(). Verify how the same exception is added twice, then check the telemetry output for a single launch failure. Done means one app launch error produces one set of error properties rather than duplicate entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
devtools, observability-sre
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.