microsoft / microsoft/vscode-pull-request-github
GitHub Enterprise sign-in prompt silently missing when repo has GitHub-style remote but github-enterprise.uri unset
Open
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 795
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 46
Description
Environment
- Extension version: 0.156.0
- VS Code Version: 1.121.0-insider
- OS: macOS (Darwin)
- Repository Clone Configuration: single repository, cloned via SSH
- GitHub Product: GitHub Enterprise Server
Steps to Reproduce
- Open a folder whose git remote is a GitHub Enterprise Server repo over SSH (e.g.
ssh://git@ghe.example.com/org/repo.git), without ever having setgithub-enterprise.uri. - Open the "GitHub Pull Requests" / Source Control view.
- Observe the sign-in area of the view.
Expected behavior
Some sign-in prompt or message appears, so there's something to act on.
Actual behavior
The view renders completely empty — no button, no message, no error. There's nothing to click and no indication of what's wrong.
Manually setting github-enterprise.uri to the GHE server's base URL (e.g. https://ghe.example.com) in settings.json makes it work. I don't know if that's the right way to do it or if that's documented.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.