microsoft / microsoft/vscode-pull-request-github
Create Pull Request widget doesn't respect keybinding "when" clause
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 796
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 46
Description
Type: Bug
- Have a keybind with a
whenexpression which is not supposed to trigger when an input element has focus, such as the following:!editorTextFocus && !inputFocus || editorTextFocus && vim.active && vim.mode == 'Normal' - Place the cursor into the "title" or "comment" sections of the "Create" panel when making a pull request
- Press the keybind
- Observe that the keybind is triggered
I was unable to use the "View Context Keys" developer tool action to view the context keys that were set on this panel so as to update my when expression - it highlighted the panel but didn't change to a "+" to allow selection. Additionally, my normal vim input bindings do not function in these inputs, it would be great if that could be fully functional. I have "open file..." bound to the spacebar due to Vim, so it is not possible to write PR titles/descriptions at present.
Can't 100% confirm if this worked before. I've been only recently using the plugin and am not 100% certain I've actually updated the title/description in this widget before. I feel like I must have, though.
Extension version: 0.104.1
VS Code version: Code 1.97.2 (Universal) (e54c774e0add60467559eb0d1e229c6452cf8447, 2025-02-12T23:20:35.343Z)
OS version: Darwin arm64 24.3.0
Modes:
A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
2i9eh265:30646982
962ge761:30959799
2e7ec940:31000449
pythontbext0:30879054
cppperfnew:31000557
dwnewjupytercf:31046870
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc1:31192215
iacca1:31171482
5fd0e150:31155592
dwcopilot:31170013
6074i472:31201624
dwoutputs:31242946
customenabled:31248079
9064b325:31222308
copilot_t_ci:31222730
jda6j935:31233686
copilothoveron:31248524
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Reproduce the keybinding in the Create Pull Request panel, then inspect how its title and comment inputs expose context keys and handle keybindings; done means the reported when clause is respected while those inputs remain usable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100