microsoft / microsoft/vscode-pull-request-github
Make pr.goToNextDiffInPr work for Pull Requests in PULL REQUESTS tree list?
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 795
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 46
Description
Based on the below comment, the pr.goToNextDiffInPr only works on "checked out PRs", could it be changed to work on the PRs open through "Click the icon of GitHub Pull Requests on the left bar -> PULL REQUESTS -> All Open -> expand any PR in the list"? The error message "Current file isn't a pull request diff." is showing up for now when running the pr.goToNextDiffInPr, but I think this is actually a pull request file?
https://github.com/microsoft/vscode-pull-request-github/issues/6247#issuecomment-2376579694
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the pr.goToNextDiffInPr command from the Pull Requests extension and compare its behavior for checked-out PRs with PRs opened from the PULL REQUESTS tree list via All Open. Use the reported "Current file isn't a pull request diff" message as the reproduction signal; done means the command navigates to the next diff for an expanded PR in that list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, typescript
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100