microsoft / microsoft/vscode-pull-request-github
Unclear behavior when having two changes, one inside a comment and one outside
Open
@alexr00 is already working on this.
Since Aug 27, 2024.
bug
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 796
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 46
Description
Testing #6160
I did two change, one inside a comment and one outside and then ran the action from the SCM viewlet. Here is what happend:
- got the dialog.
- the one inside the comment got converted but the diff didn't revert. I would have expected to see that happening since the suggestion got created.
- the other diff stayed, which is IMO correct.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.