microsoft / microsoft/vscode-pull-request-github
Adding a comment is always associated with a review
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 796
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 46
Description
- Extension version: v0.92.0
- VSCode Version: 1.91.0
- OS: macOS Sonoma 14.5
Whenever I add a comment through the extension, it shows up as a review comment, see e.g. https://github.com/mne-tools/mne-python/pull/12707#pullrequestreview-2171610586. However, that's not what I want to do, and I think that's also not what is supposed to happen. What should happen instead is that a normal comment is added to the discussion.
Steps to Reproduce:
- Check out some PR
- Add a new comment
- The comment is associated with a review, which should not happen in my opinion
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the VS Code extension by checking out a pull request and adding a comment. Trace the extension's comment-submission flow and compare the resulting review association with the intended discussion comment; done means a newly added comment is posted as a normal discussion comment rather than a review comment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100