microsoft / microsoft/vscode-pull-request-github

Checkout process should better handle slower speeds

Open
#192 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

performance ux
Dominant language
TypeScript
Stars
2.6k
Forks
795
Avg merge
1d 4h
Merged PRs (30d)
46

Description

Noticed this when I was on a slow connection, clicking on "Checkout" instantly disables the button, but while the process continues the button re-enables but the UI hasn't changes to reflect the change and I'm able to click on "Checkout" again.

Repro

  1. Throttle speed
  2. Open PR
  3. Click on "Checkout"
  4. See "Checkout" button get re-enabled after a few seconds while page is still processing (see progress bar in sidebar)

Expected

  • Button should only be re-enabled once UI has updated

gif

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with throttled network speed in the pull request checkout flow, watching the Checkout button and the sidebar progress bar. Trace the checkout UI entry point and its processing state; done means the button stays disabled until the UI reflects the completed checkout update.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript, vscode
Domain
developer-experience, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.