microsoft / microsoft/vscode-powerquery

.[char] as a numeric literal prevents errors from being raised

Open
#93 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
108
Forks
25
Avg merge
8d 22h
Merged PRs (30d)
2

Description

PQ - 2021-07-04 gif

  • d isn't throwing an error
  • when d is enabled, it hides errors b would raise

The textmate scope is constant.numeric.integer.powerquery for the section before the .

Environment

powerquery.vscode-powerquery 0.1.19

To Reproduce

[<number>].<char><anything>
  • It's . followed by a single text character that triggers it. The rest can be anything.
  • the prefix is optional
  • It occurs with values outside the hex literal range (non-a-f)
let   
    a = .z
in
    a

Expected Behavior

PBI returns an Token Comma Expected error
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the provided Power Query example with .z and inspect the TypeScript handling of numeric literals and the following text character. Confirm that the invalid form reports the expected Token Comma Expected error and no longer suppresses related errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.