microsoft / microsoft/vscode-powerquery-sdk

Set credentials fails - referencing multiple data source kinds in same connector

Open
#191 0 comments 0 reactions 1 assignee View on GitHub

@mattmasson is already working on this.

Since Mar 18, 2024.

Dominant language
TypeScript
Stars
92
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Preflight Checklist
Power Query SDK

2.0.0

Regression From

No response

Platform

Windows

Architecture

x64

OS Version

No response

VSCode version

No response

PQSdkTool Path

No response

Bug Description

When a test M file contains references to multiple data source kinds defend by the same connector, setting credentials fails.

Steps to Reproduce
  1. Create a connector that defines multiple data source kinds:
    [Version = "1.0.0"]
    section BenTest;
    
    [DataSource.Kind="BenTest"]
    shared BenTest.Data = () => ...;
    
    [DataSource.Kind="BenTest2"]
    shared BenTest2.Data = () => ...;
    
    BenTest = [ Authentication = [ Anonymous = [] ]];
    BenTest2 = [ Authentication = [ Anonymous = [] ]];
    
  2. Create a test M file that references more than one of these data source kinds:
    section Tests;
    
    shared A = BenTest.Data();
    
    shared B = BenTest2.Data(); 
    
  3. Run "set credentials".
Actual Experience

Set credentials process prompts the user to select which data source kind they are setting credentials for and the M test file, as well as the credentials kind (all as expected; good), before erroring with the following (bad):
image

Expected Experience

Credentials for the specified kind should have been successfully set.

Additional Context

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.