microsoft / microsoft/vscode-mssql

[Bug]: New connections always save password. Save password checkbox does not work.

Open
#22,945 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Triage: Needed User-filed
Dominant language
TypeScript
Stars
1.9k
Forks
610
Avg merge
2d 3h
Merged PRs (30d)
97

Description

### Description

Expected the MSSQL extension to forget passwords of new SQL login authentication type, if save password checkbox is unchecked.
But the extension saves the password anyway. The checkbox is just ignored.

Image

### Steps to Reproduce

Create a new connection to database.

Choose SQL Login authentication type and left Save Password unchecked.

Future attempts to use this connection just work and don't ask for the password again.

### Affected Area

- [x] Connection dialog (SQL Server | Azure browse/Fabric browse)
- [ ] Query editor
- [ ] Query results panel
- [ ] Object Explorer
- [ ] GitHub Copilot integration
- [ ] Preview/Edit data
- [ ] Table Designer
- [ ] Schema Designer
- [ ] Schema Compare
- [ ] Local SQL Server Container provisioning
- [ ] SQL database in Fabric provisioning
- [ ] DACPAC/BACPAC export/import
- [ ] SQL Database projects
- [ ] Query Plan Visualizer
- [ ] Other (please describe below)

### If you selected "Other", please describe the affected area

_No response_

### Environment Information

VSCode 1.134.0
Extension version: 1.45.1
Windows version: 11
Connection type tested: SQL server.

### Confirmation

- [x] I have searched existing issues and couldn't find a match
- [ ] I want to work on this issue

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the SQL Login connection dialog flow and trace how the Save Password checkbox controls credential persistence for new connections. Reproduce the issue with the checkbox unchecked, then verify that the password is not reused while checked connections continue to work as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql, typescript
Domain
authentication, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.