microsoft / microsoft/vscode-mssql
[Bug]: Formatting stored procedure parameters
- Dominant language
- TypeScript
- Stars
- 1.9k
- Forks
- 610
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 97
Description
### Description
Expected the formatter to put stored procedure paramters on their own line indented in
Like:
```
CREATE OR ALTER PROCEDURE procname
@param1 int, -- This is param1
@param2 int, -- This is param2
@param3 int -- This is param3
AS
```
Instead it formatted it as such:
```
CREATE OR ALTER PROCEDURE procname
@param1 INT, @param2 INT, @param3 INT -- This is param1
-- This is param2
-- This is param3
AS
```
### Steps to Reproduce
Formatted existing stored procedures with new extension
### Affected Area
- [ ] Connection dialog (SQL Server | Azure browse/Fabric browse)
- [ ] Query editor
- [ ] Query results panel
- [ ] Object Explorer
- [ ] GitHub Copilot integration
- [ ] Preview/Edit data
- [ ] Table Designer
- [ ] Schema Designer
- [ ] Schema Compare
- [ ] Local SQL Server Container provisioning
- [ ] SQL database in Fabric provisioning
- [ ] DACPAC/BACPAC export/import
- [ ] SQL Database projects
- [ ] Query Plan Visualizer
- [x] Other (please describe below)
### If you selected "Other", please describe the affected area
Issue with Formatter
### Environment Information
Identifier: ms-mssql.mssql
Version: 1.45.0
### Confirmation
- [x] I have searched existing issues and couldn't find a match
- [ ] I want to work on this issue
Contributor guide
No contributing guide indexed for this repository
Research direction
Reproduce the issue in the ms-mssql.mssql formatter using an existing stored procedure with parameter comments. Inspect how stored procedure parameters and their comments are formatted; done means each parameter appears on its own indented line with its corresponding comment, matching the expected example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sql, typescript
- Domain
- databases, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100