microsoft / microsoft/vscode-makefile-tools

A broken makefile that recurses kills server

Open
#397 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

repro needed
Dominant language
TypeScript
Stars
242
Forks
78
PR merge metrics
No merged PRs in 30d

Description

If you open a folder remotely that contains a broken makefile which can recurse infinately then simply opening a remote folder kills the server before you have a chance to stop it.
Suggestion:
If Makefile tools fails to initialise on a run then suspend the tool for that folder until user action corrects the error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue by opening a remote folder containing a recursively broken Makefile, then trace the Makefile Tools initialization path. Done means the server remains usable and the tool is suspended for that folder after initialization fails, until the user corrects the error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
build-system, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.