microsoft / microsoft/vscode-makefile-tools

Automation shell override causes invalid options.shell property

Open
#346 6 comments 8 reactions 1 assignee View on GitHub

@andreeis is already working on this.

Since Feb 6, 2024.

enhancement
Dominant language
TypeScript
Stars
242
Forks
78
PR merge metrics
No merged PRs in 30d

Description

My settings.json includes the following:

    "terminal.integrated.automationProfile.windows": {
      "path": "${env:windir}\\System32\\cmd.exe",
      "args": [],
      "icon": "terminal-cmd"
    },

I admit I'm pretty confused about whether this option is supposed to be a string (a key of terminal.integrated.profiles.windows) or an object, but the TypeScript types suggest it's supposed to be an object. In this state, the Makefile extension says this:

TypeError [ERR_INVALID_ARG_TYPE]: The "options.shell" property must be one of type boolean or string. Received an instance of Object
Preprocessing: "undefined"
Configure failed.
Configure elapsed time: 0.388
Dryrun timeout. Verify that the make command works properly in your development terminal (it could wait for stdin).

(No dryrun.log was generated.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.