microsoft / microsoft/vscode-makefile-tools
Review all the globals
Open
Nobody has claimed this yet.
engineering
- Dominant language
- TypeScript
- Stars
- 242
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
Review all the globals and their access.
Use getters/setters when working with them in their own file (they are already used when other files access them).
Evaluate whether some need more encapsulation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying the globals and reviewing how each is accessed, using the existing getter/setter pattern in the globals' own files as a reference. Done means each global's encapsulation has been evaluated and access is appropriately restricted or exposed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100