microsoft / microsoft/vscode-makefile-tools

Improve Makefile --dry-run output parsing

Open
#185 8 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement Feature: accuracy
Dominant language
TypeScript
Stars
242
Forks
78
PR merge metrics
No merged PRs in 30d

Description

I am dealing with legacy code's Makefile which issues compile commands in the form of:

ENV_VAR_1=XX ENV_VAR_2=YY g++ ....

This makes vscode-makefile-tools not parse the include paths, somehow, so I guess it fails in parsing the dry-run output. If you tell me where are the logs I can check that and provide that for you.

I propose that --dry-run output parsing takes care of eventual env vars being prepended to the command.

I patched our Makefiles manually to avoid such environment variables, which are not needed, by being prendend but it would be best if vscode-makefile-tools would do so!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dry-run output parser and reproduce the issue with a command beginning with ENV_VAR_1=XX ENV_VAR_2=YY g++. Check how the parser identifies the compiler and include paths; done means environment-variable-prefixed commands parse their include paths correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, typescript
Domain
build-system, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.