microsoft / microsoft/vscode-makefile-tools
Consider -f and -C from makefile.configurations.makeArgs as well besides makefilePath and makeDirectory
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 242
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
We need validation and preferences rules for when makeDirectory and makefilePath are defined at the same time with makeArgs (-f, --file, --makefile, -C, --directory).
Plus, when makefilePath is not defined and there is no makefile in the root, but there is -C or --directory in makeArgs, search for the file there as well.
Currently (as of PR https://github.com/microsoft/vscode-makefile-tools/pull/161) the extension searches for this scenario only in whatever place makeDirectory points to, but it doesn't parse the makeArgs for this yet.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing configuration handling for makeDirectory, makefilePath, and makeArgs, focusing on the existing search behavior described for PR #161. Done means validating conflicting options and honoring -f/--file/--makefile and -C/--directory when locating the Makefile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100