microsoft / microsoft/vscode-makefile-tools
More advanced pre-configure return code analysis
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 242
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
Depending how a pre-configure script is written, we may calculate wrong the return code.
The bash API returns only the last command error code, so we lose any previous error which is relevant if the last tool invocation returned success.
To mitigate this, we introduced some error whenever stderr is triggered, but that may happen even if that tool that is currently running succeeds in the end. Not 100% correct either.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the pre-configure script handling and its Bash return-code and stderr behavior. Reproduce a script where an earlier command fails but the last succeeds, then compare it with a successful tool invocation that writes to stderr. Done means the return-code behavior is specified and both cases are covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, typescript
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100