microsoft / microsoft/vscode-loader

compile to es6?

Open
#20 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
179
Forks
62
Avg merge
18h 42m
Merged PRs (30d)
2

Description

When target is set to es6, it produces an error:

tsc -p src/core/tsconfig.json && tsc

node_modules/typescript/lib/lib.es2015.collection.d.ts:28:14 - error TS2687: All declarations of 'size' must have identical modifiers.

28 readonly size: number;
~~~~

It seems that problem is with versions of types/node@ and typescript...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running tsc -p src/core/tsconfig.json && tsc with the target set to ES6 and inspect the TypeScript and @types/node versions involved. Read src/core/tsconfig.json and the reported node_modules/typescript/lib/lib.es2015.collection.d.ts declaration. Done means the ES6 compilation no longer reports the conflicting size declaration.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.