microsoft / microsoft/vscode-livepreview

Consider respecting server root even if the directory doesn't exist

Open
#425 0 comments 2 reactions 1 assignee View on GitHub

@andreamah is already working on this.

Since Jan 25, 2023.

bug polish
Dominant language
TypeScript
Stars
596
Forks
119
Avg merge
1d 4m
Merged PRs (30d)
5

Description

Testing microsoft/vscode#172071

  1. Set the server root to a path that doesn't exist
  2. Open preview

Problem
Right now, changing the server root to a path that doesn't exist makes us fall back to use the workspace root. I find this makes debugging issues with the server root setting confusing

Instead I'd expect that the live preview always uses the server root setting, even if the folder it points to does not exist

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.