microsoft / microsoft/vscode-languageserver-node
Add signatureHelp/resolve support, because signature help takes too long with multiple overloads
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 404
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 14
Description
After we added "doc comment" support for signature help to our C/C++ extension, getting the results for 20+ overloads takes too long, so we want to send the documentation as part of a signatureHelp/resolve, just like in the completionItem/resolve case. We would get the signatureHelp/resolve message when the user uses the up/down arrow to change which signature is shown.
This would also allow us to reset the active signature after the user types, because currently if the user selects the 20th overload, it gets reset back to 1 after typing because we never get a "resolve" message that identifies the overload the user has switched to.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing completionItem/resolve behavior and the current signature-help protocol definitions. Trace how signature selection changes on up/down navigation and after typing. Done means the protocol and implementation support deferred signature documentation while preserving the selected overload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, developer-experience
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100