microsoft / microsoft/vscode-languageserver-node

Make it possible to know if WorkDoneProgressReporter is a NullProgressReporter

Open
#1,811 1 comment 0 reactions 1 assignee View on GitHub

@dbaeumer is already working on this.

Since Jun 27, 2026.

feature-request
Dominant language
TypeScript
Stars
1.8k
Forks
404
Avg merge
2d 8h
Merged PRs (30d)
14

Description

Back in the days I've reported an issue in pyright about wrong handling of client-initiated progress. This was fixed (worked around) in https://github.com/microsoft/pyright/pull/2546 and that fix was later changed to use a small utility function from https://github.com/microsoft/pyright/blob/ede08a0211b7558ebd5eedee6d7fd539c753486b/packages/pyright-internal/src/common/lspUtils.ts#L67-L73 (due to attachWorkDone from this library becoming internal).

The whole issue stemmed from how this library implements progress handling and how it makes it very hard to know if the progress reporter is "null" or delivered by the client. I think this library should make some change to make this distinction clear so that servers can make an informed decision on how to handle progress.

@dbaeumer

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.