microsoft / microsoft/vscode-languageserver-node
Server is not closed when child process not started
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.8k
- Forks
- 404
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 14
Description
https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/node/main.ts#L389
https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/node/main.ts#L402
When error happened on child process start, the server created by createClientPipeTransport and createClientSocketTransport is not closed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with client/src/node/main.ts at lines 389 and 402, then trace the error paths when child process startup fails in createClientPipeTransport and createClientSocketTransport. Confirm how the server is created and what cleanup is currently reached; done means both transports close when startup reports an error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100