microsoft / microsoft/vscode-languageserver-node

LanguageClient.sendNotification fails due to change in state due to stopping client.

Open
#1,616 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
1.8k
Forks
404
Avg merge
2d 8h
Merged PRs (30d)
14

Description

We are working on an LS for Odoo, and we have encountered an error that happens due to change in state.

Let me describe the scenario:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in client/src/common/client.ts at sendNotification, $start, start(), and activeConnection(), following the state transitions during concurrent notification and stop calls. Reproduce the Odoo language-server scenario and inspect existing client tests, if present; done means stopping or stopped clients no longer raise this notification error while normal sends still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.