microsoft / microsoft/vscode-languageserver-node

Add support for `NotebookEdit` in `WorkspaceEdit`

Open
#1,336 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request
Dominant language
TypeScript
Stars
1.8k
Forks
404
Avg merge
2d 8h
Merged PRs (30d)
14

Description

Currently there is no way to provide diffs at the notebook level. We currently receive notebook changes in the form of notebook synchronization events.

The Notebook features that are available from TS APIs like WorkspaceEdit.set is currently not exposed to Language Servers. Having this will allow language servers to perform notebook level "formatting" (restructuring), refactoring, insert/delete/re-order cells.

Adding NotebookEdit support can generally allow updating notebooks via formatting, code action, or any request.

Notes:

ref: https://github.com/microsoft/vscode/issues/204544

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the linked VS Code WorkspaceEdit and NotebookCellData API definitions, then trace the corresponding WorkspaceEdit types in this repository. Done means Language Servers can represent NotebookEdit changes and create new notebook cells through the exposed API, with behavior aligned to the referenced core API.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.